Recalculate element width/height on window resize#68
Open
South-Paw wants to merge 1 commit intoWinterCore:masterfrom
Open
Recalculate element width/height on window resize#68South-Paw wants to merge 1 commit intoWinterCore:masterfrom
South-Paw wants to merge 1 commit intoWinterCore:masterfrom
Conversation
Author
|
Note that the |
|
@WinterCore - would love to use your library but the issue regarding resizing behaviour may require us to use something else. Could you review this pull request? |
|
Great job on this PR |
|
@WinterCore any chance you could review this PR and release a new version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I believe this addresses #32 and fixes the element sizing when the window is resized.
To keep it performant, I've added the
use-debouncepackage, defaulted the debounce to50msand added an option for users to configure the debounce if required.Tested on my website and seems to have resolved the odd sizing when I played with the window size and the font changes size between different breakpoints.
Thanks 👍